SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5770897508
@zeguilherme99 thanks for volunteering — connector-tablestore is yours, no one else in this thread has claimed it. To keep it consistent with the other slices here, please: - Migrate only the declarative-eligible checks to `optionRule()` + `Conditions.*` (required/nonblank on existing required options, optional options registered as optional with their current defaults). Leave client construction, credential/network checks and other runtime validation untouched, and do not change runtime behavior. - Before opening the PR, post a short note here listing exactly which tablestore options you intend to mark required/nonblank and which stay optional, so the contract is agreed up front. - Open one PR against `dev`, referencing this issue, with focused factory tests covering a valid configuration plus each required option missing, empty and whitespace-only, and matching EN/ZH connector docs. Once the option list is posted I'll confirm the scope and you can proceed. <!-- streview-comment:1228 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
