SEZ9 commented on issue #12267:
URL: https://github.com/apache/seatunnel/issues/12267#issuecomment-5771009781

   Thanks @1362227089 for opening the PR and linking it here — that keeps us on 
a single implementation path.
   
   When it is ready for review, please make sure it covers the points already 
discussed in this thread:
   
   - Normalize exact duplicate `TableId` values at the discovery boundary (the 
`TableDiscoveryUtils.listTables()` path called from 
`PostgresDialect.discoverDataCollections()`), preserving catalog/schema/table 
identity, rather than changing the downstream map to silently pick a winner.
   - Extend the existing PostgreSQL CDC test coverage with a duplicate-row 
regression that asserts a single `TableId` is produced.
   - Confirm that an ordinary PostgreSQL discovery result is unchanged.
   - If the HighGo JDBC driver can be made available in the test environment, a 
HighGo-backed integration case would be welcome; if not, please note that in 
the PR description.
   
   We can continue the discussion on the PR. I'll keep this issue open until 
the fix lands.
   
   <!-- streview-comment:1232 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to