SEZ9 commented on issue #12415: URL: https://github.com/apache/seatunnel/issues/12415#issuecomment-5771303420
Thanks for the detailed report and root cause analysis. The proposed direction looks reasonable: in `MysqlCreateTableSqlBuilder#buildColumnIdentifySql` (and the OceanBase MySQL-mode builder), emit `NOT NULL` for any column that is part of the table's primary key, in addition to the existing `!column.isNullable()` case, without changing non-key nullable columns or the behavior when `create_index = false`. Since you've indicated you're willing to submit a PR, please go ahead and link it here. A unit test in `MysqlCreateTableSqlBuilderTest` asserting that a nullable key column is written as `NOT NULL`, plus an E2E case covering an auto-created target table with `primary_keys` configured, would be great. <!-- streview-comment:1237 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
