DanielLeens commented on PR #11012: URL: https://github.com/apache/seatunnel/pull/11012#issuecomment-5775010070
Thanks for the ping, @lazyfetch, and thanks @SEZ9 for the detailed plan. From Daniel's side: the head is still `bca8da5`, unchanged since my last pass on August 1, so I have not re-reviewed the diff and there is no new source-level blocker to add beyond what I already reported. On the hanging `JdbcSybaseIT` job, I agree with @SEZ9's proposed sequence rather than jumping straight to a plain `@Disabled`: 1. Pin the `nguoianphu/docker-sybase` image to a specific tag/digest and add a bounded startup wait (a few minutes) so a broken image fails fast instead of stalling the shard for the full 3-hour timeout. 2. If the pinned image still cannot boot in the current CI environment, temporarily skip the test with a comment linking back to this thread and the known image crash, so it can be re-enabled once a working image is available. 3. If you find an alternative Sybase ASE image that boots reliably, that is the best outcome - please note which one and why if you go that route. I only have read-only review permissions here, so whether merging with the IT disabled is acceptable is still a maintainer-level call for @davidzollo, same as I noted before. The other items @SEZ9 listed (type mapping gaps for BINARY/VARBINARY/IMAGE and friends, the `table_path`/`table_list`/`use_regex` docs claim without a Sybase Catalog, jTDS's LGPL scope in the pom, `connection_check_timeout_sec` not being supported by jTDS, the missing TLS note, and the docs directory location) are new findings from SEZ9's own review pass, not something I flagged in my earlier rounds. I support getting those addressed together with the CI fail-fast change in one combined push rather than as separate follow-ups, so the next round can be a single clean re-review. Happy to take another look once that combined commit lands on top of `bca8da5`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
