SEPURI-SAI-KRISHNA commented on PR #12416: URL: https://github.com/apache/seatunnel/pull/12416#issuecomment-5771659739
Correcting myself: my comment above says the fixes are "in the push above", and that is wrong. There is no push on this PR. It merged at 04:37:33Z and my commit is timestamped 05:07:48Z, half an hour later, so it landed on my branch after this PR was already closed and never became part of it. So to be precise about what is on `dev` right now: none of the four points are addressed there. `MqttSourceTest` still says `sourceConfig` is "the third and last field", still has no `assertEquals(Boundedness.UNBOUNDED, restored.getBoundedness())` on the restored source, and still asserts only that `createReader` does not throw. I will open a follow-up PR with exactly those changes and link it here. `MqttSourceConfigTest` is already identical to `dev`, so the follow-up touches one file. Apologies for the noise, and thanks @nzw921rx for merging. Nothing in what merged is wrong; it is just missing the four improvements @SEZ9 and @DanielLeens identified afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
