DanielLeens commented on issue #12439:
URL: https://github.com/apache/seatunnel/issues/12439#issuecomment-5776196365

   Classification: B / Connector-V2 Hudi exactly-once delivery.
   
   Thanks for framing the failure window precisely. I rechecked current `dev`: 
`HudiSinkWriter.prepareCommit()` flushes the writer but returns no commit 
information, and `HudiSink` does not create a committer. That means checkpoint 
completion cannot currently own the visibility transition for a Hudi instant, 
so the at-least-once diagnosis is valid.
   
   There is now one implementation path: #12440. Please keep further 
implementation and review on that PR rather than opening a competing change. 
The exact-once claim needs to be demonstrated at the checkpoint boundary: an 
instant must become visible only after the successful checkpoint completion 
callback; abort, task failure, and restore must not expose or duplicate records 
from an uncompleted checkpoint; and the commit/state serialization must 
preserve the recovery decision without changing existing default behavior.
   
   The focused unit tests and Hudi E2E should include an induced 
failure/restart around the commit boundary, not just a successful checkpoint. 
The documentation should also state which delivery semantics apply when the new 
mode is not selected. Once #12440 has a complete, green CI result and those 
recovery cases are evidenced, it can receive a full merge review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to