SEPURI-SAI-KRISHNA commented on PR #12436: URL: https://github.com/apache/seatunnel/pull/12436#issuecomment-5781505596
Thanks @davidzollo, and the point is fair. Taking it. For the record rather than as a defence: #12408 is the Zeta E2E test for the MQTT source and #12436 is unit-level assertions in `connector-mqtt`, so they were different modules and different layers rather than two attempts at the same thing. But you are right that from the outside they read as one concern arriving twice, and the count is worse than those two: #12406, #12410, #12416, #12436 and #12408 are five PRs on MQTT source coverage in three days. The real cause is worth stating because it is fixable. Each of #12410, #12416 and #12436 exists because review feedback arrived after the previous PR had already merged, so there was nothing left to fold it into. #12436 is the clearest case: it merged at 04:37 and my commit with the review fixes is timestamped 05:07, half an hour late. I should have checked the merge state before pushing rather than after. What I will do differently: there are two MQTT items still outstanding, a `MqttSink` Java-serialization round-trip test that @DanielLeens asked for as #12416 Issue 2, and a one-word comment correction he flagged on #12436 (it says the `max_queue_size` default is 2048; it is 1000). Those would naturally have been two more PRs. They will be one, and that will be the last MQTT PR from me unless something is actually broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
