SEZ9 commented on issue #12461: URL: https://github.com/apache/seatunnel/issues/12461#issuecomment-5806717674
Thanks for the detailed proposal; moving the source install into `seatunnel-cli/.venv` and handling the `build_editable` failure both sound reasonable, and the `.venv` directory being in `.gitignore` already helps. A few things to keep in mind for the PR: - Keep `setup.sh` idempotent: re-running it with an existing, working `.venv` should reuse it rather than recreate it, as you describe. - Make sure the `virtualenv` fallback removes the partial directory before retrying, and that the final error message names the missing package when neither `python3 -m venv` nor `virtualenv` works. - Please update the `seatunnel-cli` docs to mention `source .venv/bin/activate` (or calling `.venv/bin/seatunnel` directly) so users do not expect `seatunnel` to be on `PATH` right after `setup.sh` finishes. One question: would you consider letting callers point the script at an environment they have already selected, so CI or users with their own setup are not forced into `.venv`? If you prefer to keep the first PR minimal, a follow-up is fine too. Looking forward to the PR! <!-- streview-comment:1278 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
