SEZ9 commented on PR #12418: URL: https://github.com/apache/seatunnel/pull/12418#issuecomment-5806897206
@Vivek1106-04 Two small follow-ups on the fixture design, nothing blocking: 1. Your note that `expected` is slightly early (because `pendingCounter` is incremented just before the `schedule(..., interval)` call, so each sample also includes the end of the previous trigger body, equally on both revisions) is fine with me, but please put it as a comment next to the spin loop so nobody later "fixes" it. 2. For the iteration-level teardown skip guard: what fixed share of invocations do you have in mind, and could the skip count (split into "previous checkpoint still pending" vs "setup overran") be printed per iteration even when the run passes? That keeps a borderline run visible instead of silently accepted. Otherwise nothing to add beyond my last comment; I'll do the final pass once the fixture is pushed. <!-- streview-comment:1280 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
