junjunclub commented on PR #12431: URL: https://github.com/apache/seatunnel/pull/12431#issuecomment-5816254666
@DanielLeens Thanks for the detailed review, all good catches. Rebased on dev and pushed 0fb2794c2. The main one (Issue 2): I went with option A. The validator just calls buildJedis() now and does a PING (or INFO for cluster) before closing, so whatever auth the runtime does, dry-run does the same. Dropped the ACL SETUSER note from the Javadoc and docs since it's no longer true. Added a real ACL user to the IT so the user option actually gets tested against a server. For the port race I'm keeping a ServerSocket open that just closes accepted connections, instead of releasing the port first. Malformed nodes now go through the same catch as everything else, so they come out as REDIS_CONNECTION_ERROR. PR description is cleaned up too. One thing to note: since it's using buildJedis() now, the 10s timeout is gone and it uses the jedis default (2s). Docs updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
