SEZ9 commented on PR #11856: URL: https://github.com/apache/seatunnel/pull/11856#issuecomment-5825959553
Thanks for the detailed follow-up and for re-checking the review body via the API — agreed the cut-off looks like a rendering artifact rather than a content gap. Consolidating where things stand: **F1 – marker published from `ManagedService.shutdown()`** - Agreed the Hazelcast-version dependency note for `markLocalGracefulMemberRemoval()` is a recommended fix not yet landed (`dc2c64103c` is unchanged). Please add a short comment near that method in `SeaTunnelServer.java` stating that correctness relies on `LifecycleServiceImpl.shutdown()` firing `SHUTTING_DOWN` before distributed-object proxies stop being served, and noting the Hazelcast version this was verified against. - Test coverage: class-level `Tests run: 10, Failures: 0, Errors: 0, Skipped: 2` for `ClusterFaultToleranceIT` from run `35240527669` is noted. A method-level result for `testGracefulShutdownPublishesMemberRemovalMarker` is still unconfirmed — please attach the per-method surefire line for it and confirm it is not one of the 2 skipped tests. **F2 – destructive consume / no physical expiry** The `CoordinatorService.java:2185` explanation was cut off mid-sentence in the thread, so I can't act on it yet. Could you restate briefly: (a) whether the marker is read non-destructively before task-failure processing and when it is cleared, and (b) the intended behavior if the master fails over between the read and the clear? **F3–F8** Since `dc2c64103c` is unchanged, these remain open as written in the previous review (String vs `JobException` payload in `TaskExecutionState`, eviction for `engine_gracefulMemberRemoval`, message-pattern-based WARN downgrade in `PhysicalVertex`, persisted error payload change, docs, and the duplicated offline-message template). A quick note on which you plan to address in the next push versus defer would help me track the thread. Once the new commit is up I'll re-review against these points only. <!-- streview-comment:1304 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
