SEZ9 commented on issue #12484:
URL: https://github.com/apache/seatunnel/issues/12484#issuecomment-5842614359

   Thanks for the detailed analysis and data. This reads as a reasonable 
sub-task of #11513 and lines up with the impacted-module approach from #11515.
   
   One question on scope: you note that some connector E2E modules (Kafka, 
RocketMQ, Elasticsearch, CDC) declare `seatunnel-transforms-v2` as a 
dependency. Should the `transforms` route include those modules, or is the 
intent to rely on `-pl seatunnel-transforms-v2 -amd` unit tests, 
`transform-v2-it-part-1/2`, `engine-v2-it`, and the single fixed canary shard? 
Clarifying that will help evaluate the coverage trade-off and settle the canary 
set you left open.
   
   Since #12474 adds `ExampleUdfIT` to a job, it would be good to make sure the 
new `transforms` route selects that job too, so transform-only PRs keep that 
test covered.
   
   <!-- streview-comment:1324 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to