goutamadwant commented on PR #12473: URL: https://github.com/apache/seatunnel/pull/12473#issuecomment-5848011666
Thanks for the review. Addressed in the latest commits: 1. **Re-run finished between two ticks:** if the newest `Build` check completed before the attempt's `run_started_at`, a new check is created with the attempt's result ([L454-L503](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L454-L503)). 2. **`Dead links`:** treated as non-blocking in both the cancelled path and the queued-parent path ([L52-L54](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L52-L54), [L234-L251](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L234-L251), [L309-L315](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L309-L315)). 3. **Same-named check runs:** verified on my fork that the PR rollup shows only the newest one (same as the two `Build` checks on #12372). The updater reads all pages and uses the newest; if the listing is incomplete it skips the PR for that tick ([L345-L394](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L345-L394)). 4. **`started_at`:** set to the attempt's `run_started_at` ([L496-L498](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L496-L498)). 5. **Harness:** not committed, since the script is inline YAML and CI wouldn't run it. Mock result: `dev` 9/33, this PR 33/33. Happy to add it in a follow-up. 6. **Comments added** at the sort ([L253-L254](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L253-L254)) and at `TIMEOUT_ANNOTATION` ([L46-L47](https://github.com/apache/seatunnel/blob/36fda019273ed05aaeac58bfff98357f6a063e50/.github/workflows/update_build_status.yml#L46-L47)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
