DanielLeens commented on PR #12420: URL: https://github.com/apache/seatunnel/pull/12420#issuecomment-5852897045
CI recovery check on this exact head (`ad81bd9`, the commit I already reviewed and approved). All CI lanes in the fork run have now completed successfully, including `jdbc-connectors-it-part-1` on both JDK 8 and 11 — the specific lane I said I wanted to see turn green before merge in my previous review, since this PR's new E2E lives there. Nothing else has changed since my last review: no new commits, no new discussion. My conclusion stands as-is — **Ready to merge, no blockers**. Issues 1 and 3 (Medium: the still-sequential `Statement.cancel()`/`Connection.close()` teardown, and the missing dedicated unit test for the engine-side `cancelRequested` replay race) and Issue 2 (Low: noisy WARN logs on a normal cancel) remain open as non-blocking follow-ups for a future PR. Thanks again for the thorough work on this, @zhangshenghang! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
