DanielLeens commented on PR #12414: URL: https://github.com/apache/seatunnel/pull/12414#issuecomment-5861177857
Thanks for re-running the job, @TianHengZhuang! I just re-checked live: the head is still `fe9d1ef953d` (unchanged) and the `Build` check on that commit is now `success`. So the CI fact I quoted in my earlier comment (the failed `unit-test (8, windows-latest)` leg, which was the unrelated `TaskExecutionServiceTest` flake) is now outdated - please disregard that guidance. My approval of the code stands, and I don't see any new code-side blocker from my side. One note so the PR page doesn't confuse you: it may still show as blocked / review required. That is the repository's merge gate, which needs a maintainer with write access to give the final approval and merge - nothing further is needed from you on this PR right now. Thanks again for the steady work on the declarative `OptionRule` migration! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
