Rangsh commented on PR #12493: URL: https://github.com/apache/seatunnel/pull/12493#issuecomment-5861607095
@DanielLeens Thanks for the careful re-review and for calling out the carryover reset window — that one was easy to miss. Addressed against head with Option A in the latest commit: 1. **Issue 1 (High) / Issue 4** — Restored observable JobMaster behavior without putting interrupt status back on `ForkJoinPool` workers: on drain `InterruptedException`, re-interrupt **only when** `!(Thread.currentThread() instanceof ForkJoinWorkerThread)`. That covers the JobMaster caller thread that participates in `parallelStream()`, so `waitSavepointCompleted` can still see `InterruptedException` and take `savepointFailed()` instead of the retryable `CHECKPOINT_COORDINATOR_SHUTDOWN` path. Comment updated to state that contract. Locally re-ran `SavePointTest` (including `testSavePointButJobGoingToFail`) — green. 2. **Issue 2 (Medium)** — `cleanPendingCheckpoint` now calls `failSavepointDrainLocked` under the lock (maps `RESET` → `CHECKPOINT_COORDINATOR_SHUTDOWN`). The create critical section also re-checks `sharedFuture.isDone()` and `isAllTaskReady` before `createPendingCheckpoint`. 3. **Issue 3 (Medium)** — Dropped the `catch (Throwable)` in `tryTriggerPendingCheckpoint`; left unexpected-trigger-failure policy to #12442 as originally scoped. 4. **Issue 5 (Low)** — Extended `testSavepointDrainInterruptClearsGateAndAllowsTrigger` to assert the interrupt-flag contract on a non-pool thread, and added `testSavepointDrainAbortedByCoordinatorReset` for the reset window. Also added a short state outline in `startSavepoint()` Javadoc. **Local verification** - `CheckpointCoordinatorTest` (5 related tests): Failures: 0 - `SavePointTest`: Failures: 0 (Skipped: 1 pre-existing) - `BUILD SUCCESS` Would appreciate another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
