hutiefang76 commented on PR #12518: URL: https://github.com/apache/seatunnel/pull/12518#issuecomment-5876548580
Closing this for now: the new parser also changes existing configured named SQL, and I found a regression with escaped string literals. `SELECT E'can\'t' AS literal, :id AS id, 'fixed' AS other` prepares and returns `can't / 7 / fixed` with the original parser on DuckDB JDBC 1.3.1.0. With this PR, the literal-skipping regex pairs the escaped quote incorrectly and consumes `:id` as quoted text. The named parameter is left in the SQL, so preparation fails with a parser error at `:`. The custom-SQL entry point reaches the same parser because this query has no `?`. The positional-SQL compatibility tests did not catch the named-SQL case. The special-field binding fix is still useful, but it needs to preserve existing named queries before this is ready. I will keep the patch locally while sorting out that boundary. Thanks for taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
