SEZ9 commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-5882680971
Thanks for the follow-up on F1–F8. I don't want to mark these as confirmed resolved on my side yet: nothing in this thread shows the actual diff for the fixes, and comments alone can't verify them. Could you point to the specific commits or changed files that address each of the following? - **F1 / F3 / F7** – the `RequestFuture.get()` blocking behaviour and the timed `get(timeout, unit)` `TimeoutException` contract, including method-level documentation. - **F2 / F4** – `WALWorkHandler` surviving an `executeResponse()` failure, and not reusing the writer after a write failure. - **F5** – the Mockito test dependency for the `imap-storage-file` module; the original finding noted no `pom.xml` change in this PR, so please confirm where it was added. - **F6 / F8** – `batchQueryExecuteFailsStatus` no longer waiting the full write timeout per entry, and `queryExecuteStatus` no longer logging a full stack trace at ERROR on every timeout. Separately, as noted above, the `Build` check on `7f69d7f69f6` is recorded as a failure, so a green build for the current head is still outstanding before merge. Once the fix locations are linked and CI is re-run, I'm happy to close these out. <!-- streview-comment:1396 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
