SEZ9 commented on PR #12454: URL: https://github.com/apache/seatunnel/pull/12454#issuecomment-5882896443
Thanks for the ping, @CryoThrust. One note on the flaky-test side of this PR: my earlier stress-test runs were done against the PR diffs as they stood at that time, and I did not record which PR head they corresponded to, so I don't want to assume they cover `3080371ce733`. The re-review already on this thread lists what changed between `4f86cb0ac63e` and `3080371ce733`: the new guard in `PhysicalVertex.cancel()` and the updated `CheckpointCoordinatorFailoverIT`. Both touch the area I stress-tested, so I'll re-run the same setup against `3080371ce733` and post the numbers here alongside the earlier ones. No action needed from you on that; I'll leave the final merge call to the requested reviewer. <!-- streview-comment:1401 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
