hutiefang76 commented on PR #12557:
URL: https://github.com/apache/seatunnel/pull/12557#issuecomment-5919829387

   Added source-type assertions for both the original and copied 
`DECIMAL(10,2)` columns, plus a short explanation of the numeric-precision 
branch. JDK 8 and 17 each pass all 8 `DuckDBCatalogTest` cases and module 
`verify`; scoped formatting and the complete PR diff checks also pass.
   
   I checked the `full_type_name` hypothesis with DuckDB JDBC 1.3.1.0. 
`character_maximum_length` is NULL, `numeric_precision` is 10, and the SQL 
returns `DECIMAL(10,2)`, so I kept that CASE expression. I also corrected the 
PR description: 38 comes from the catalog's fallback, not from the 
character-length metadata.
   
   The failed job on the previous head was 
[`JdbcOceanBaseMilvusIT.startUp`](https://github.com/hutiefang76/seatunnel/actions/runs/36647247244/job/109754242434),
 ending in `ConditionTimeout` (34 tests, 0 failures, 1 error, 3 skips). I have 
not established a baseline cause or treated that failure as cleared. The new 
push will need its own CI result.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to