yigitcan-ozturk opened a new pull request, #12574:
URL: https://github.com/apache/seatunnel/pull/12574
### Purpose of this pull request
This PR implements the approved ClickHouse Source-only validation slice
tracked in #11007.
`ClickhouseSourceFactory` currently requires `host` for presence, but empty
and whitespace-only values are not rejected declaratively.
This change adds declarative nonblank validation for the ClickHouse Source
`host` option.
### Changes
- Add `Conditions.notBlank(HOST)` to `ClickhouseSourceFactory.optionRule()`.
- Add focused `ConfigValidator` regression coverage for:
- valid nonblank host
- missing host
- empty host
- whitespace-only host
- padded nonblank host
### Regression evidence
The empty-host and whitespace-only-host cases depend on the new declarative
`notBlank(HOST)` rule.
Without the new rule, those values pass the existing presence-only
required-option validation. With the rule applied, they are rejected during
configuration validation.
### Scope
This PR intentionally changes only ClickHouse Source `host` validation.
The following behavior remains unchanged:
- connection and node construction
- username/password semantics
- `table_path` / `sql` behavior
- batch/split fallback behavior
- partition/filter handling
- sharding/node selection
- server timezone and `clickhouse.config`
- remote connectivity checks
- ClickHouse Sink
- ClickHouse File delimiter validation
### Does this PR introduce any user-facing change?
Yes.
ClickHouse Source configurations with an empty or whitespace-only `host`
value are now rejected during declarative configuration validation. Valid
nonblank values, including padded nonblank values, remain accepted.
### Tests
Added focused factory/`ConfigValidator` coverage for valid, missing, empty,
whitespace-only, and padded nonblank `host` values.
Full CI results will be verified on this PR.
Tracked under #11007.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
