hutiefang76 opened a new pull request, #12576:
URL: https://github.com/apache/seatunnel/pull/12576
### Purpose of this pull request
Fixes #12575. DuckDB SQL generation uses the JVM default locale for integer
formatting. Under ar-EG, DECIMAL precision/scale and the hash partition modulus
contain non-ASCII digits. Use Locale.ROOT for both expressions.
### Does this PR introduce _any_ user-facing change?
Yes. DECIMAL DDL and hash partition SQL use ASCII digits under all JVM
default locales. English and Chinese DuckDB docs describe this behavior.
### How was this patch tested?
JDK 8 and 17: DuckDBDialectTest and DuckDBTypeConverterTest, 61 tests on
each, no failures/errors/skips. Tests create, write and read a real in-memory
DuckDB DECIMAL table and execute the generated hash SQL under ROOT, zh-CN and
ar-EG. The new locale assertions failed against the original implementation.
Scoped Spotless, reactor `-DskipTests verify`, MarkdownTest (4 tests), and
`git diff --check` pass on the submitted revision.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
