chovy-3012 commented on PR #12403: URL: https://github.com/apache/seatunnel/pull/12403#issuecomment-5923884435
Thanks for the review and the approval, @DanielLeens. Issue 1 (non-blocking) — addressed in 5f6636daf. The two `byte[]` iv rejection tests (`testEncryptByteArrayIvThrows`, `testDecryptByteArrayIvThrows`) now also assert the thrown message contains `unsupported input type`, so they actually pin the iv guard in `resolveIv` rather than passing on the wrong-length fallback. Verified by temporarily removing the guard — both tests turn red (`expected: <true> but was: <false>`) and are green again once restored. All 38 `CryptoFunctionTest` tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
