karthik-0306 commented on PR #12573: URL: https://github.com/apache/seatunnel/pull/12573#issuecomment-5925742726
Thanks for the thorough review, and for independently re-deriving the `renameCatalogTable()` behavior rather than taking my word for it — that's exactly the kind of check I was hoping for on that part. I've addressed both Low-severity suggestions: - Test method names are now camelCase (`notBlankSinkEmptyWarehouse`, etc.) - Removed the banner comments - Negative assertions now check that the exception message names the specific failing option, verified against the actual `OptionValidationException` output (e.g. `constraint: 'warehouse' is not blank`) Full module suite still passes: `Tests run: 107, Failures: 0, Errors: 0` (`BUILD SUCCESS`). I've also enabled Actions on my fork, so CI should run on this head now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
