DanielLeens commented on issue #11007:
URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5931142175

   Classification: I / Declarative OptionRule migration tracking.
   
   I checked current `dev` at `d7e9931bea0976547e9730675e7019bbef88ad83`, the 
source factories, and the open PR set.
   
   @Nikk8091: the IoTDB Source slice is available with one correction. 
Root-level `sql` is optional because it is exclusive with `tables_configs`; it 
must not become `required`. `SingleTableValidator` currently enforces the root 
schema relationship but does not reject an explicit blank SQL value. Keep one 
Source-only PR that adds `Conditions.notBlank(SQL)` to the existing optional 
SQL validation while preserving the `sql`/`tables_configs` exclusivity. Cover 
valid root SQL with schema, explicit empty and whitespace-only root SQL, and a 
valid `tables_configs` configuration with root SQL absent. Do not change 
parsing, schemas, node URLs, credentials, partitioning, or the Sink.
   
   For MaxCompute, `endpoint` is currently presence-required only, but #12390 
is an active timeout/retry PR that already modifies `MaxcomputeSourceFactory`. 
It does not implement the endpoint rule, yet a parallel PR would conflict in 
the same factory. Please wait for #12390 to merge or close, then recheck 
current `dev` and post the refreshed narrow scope before opening a separate 
endpoint-validation PR.
   
   #12573 owns the Paimon Source/Sink/Catalog slice and currently has a failing 
Build, so please do not open a duplicate. No labels or assignees were changed 
in this pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to