SEPURI-SAI-KRISHNA commented on issue #12594: URL: https://github.com/apache/seatunnel/issues/12594#issuecomment-5965934427
Thanks @SEZ9, and no apology needed, the ordering was confusing: I opened the issue at 10:58 and the PR three minutes later, so your comment arrived while both already existed. On the closing reference: it is already there. #12595's description carries `Closes #12594` on line 18, and GitHub has recorded the cross-reference on this issue from #12595. So the two are tied together and the issue will close when the PR merges. If it is not showing for you I am happy to reword it, but I would rather not add a second one and end up with a duplicate link. On the clipped paragraph, that is the third time a comment of mine has been truncated on your end, so here is the ending in full. The two new end-to-end cases in `BasicAuthenticationIT` are exactly the two you guessed: - `testAccessWithCorrectUsernameAndWrongPassword` sends the configured username with `wrongpassword` and expects 401. - `testAccessWithPrefixOfCorrectCredentials` sends a proper prefix of both the username and the password and expects 401. The sentence that got cut was making the point that the existing negative case sends `wronguser:wrongpassword`, which gets both halves wrong, so it cannot tell whether the password is examined at all once the username has already failed. The first new case can. Both ran on CI in `engine-v2-it (8)`: `BasicAuthenticationIT` reported `Tests run: 9, Failures: 0, Errors: 0`, which is the seven existing cases plus these two. That was the one part of the change I could not execute locally, since there is no Docker on my machine, so it is good to have it confirmed by CI rather than argued. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
