SEPURI-SAI-KRISHNA commented on PR #12605: URL: https://github.com/apache/seatunnel/pull/12605#issuecomment-5977419249
Both confirmed at head `c5b287cc5`. **1. The CAST wording, on both pages.** The integral-type sentence was reworded. It no longer makes a blanket claim about integral targets; it names the four that actually reject, and `BIGINT` is deliberately absent because it still wraps. `docs/en/transforms/sql-functions.md`, lines 1124 to 1126: > Casting to `TINYINT`, `SMALLINT`, `BYTE` or `INT` | `INTEGER` throws a `TransformException` when the value is outside the target's range, for example `CAST(3000000000 AS INT)`. Use `TRY_CAST` to get `NULL` instead of an error. `docs/zh/transforms/sql-functions.md`, lines 1130 to 1132: > 注意：转换为 TINYINT、SMALLINT、BYTE 或 INT | INTEGER 时，如果该值超出目标类型的取值范围，将抛出 TransformException，例如 `CAST(3000000000 AS INT)`。若希望在这种情况下得到 NULL 而不是异常，请使用 TRY_CAST。 The floating-point paragraph follows it on both pages, en 1128 to 1131 and zh 1134 to 1136, with the same content you already approved. I also grepped both pages for any other sentence that could still overstate this. The only remaining hit is the `ROUND` note at en 673 and zh 675, which is about `digitsInt` being negative and is unrelated to `CAST`. **2. The BIGINT issue is #12612.** It is already linked from the incompatible-changes entry, so the gap does not read as an oversight. `docs/en/introduction/concepts/incompatible-changes.md` line 40, with the same line present in the zh page: > by this change; that gap is tracked separately in #12612. For what it is worth, #12612 now has your review comment on it setting out the shape of the follow-up, so the scope there is already agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
