SEPURI-SAI-KRISHNA commented on PR #12595: URL: https://github.com/apache/seatunnel/pull/12595#issuecomment-5977615410
Both done. **1. Javadoc note.** Added to `credentialMatches` in `BasicAuthFilter`, immediately after the paragraph explaining why the request value is passed first: > Verified against the OpenJDK 8u source and the JDK 17 bytecode. Both fold the length difference into the accumulator and run the loop for the full length of the first argument, so neither returns early on a length mismatch. That records the two things this thread established, so the next reader does not have to re-derive either. **2. Fresh run.** Pushing the javadoc change gives a new head, so the whole check runs again rather than just the one job that hit the `seatunnel-flink-starter-common` dependency resolution failure. Will report back here once it finishes. Nothing else changed in the diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
