hutiefang76 opened a new pull request, #12635:
URL: https://github.com/apache/seatunnel/pull/12635

   ### Purpose of this pull request
   
   Credential redaction could leave part of a quoted value behind when it 
contained spaces, delimiters or escaped quotes. It also missed JSON-style 
quoted keys and short credential values. Match complete assignment values and 
replace only the value, preserving the key, separator and quoting.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, in dev. Supported quoted assignments and recognized prefixed keys are 
fully redacted, including short values. Non-credential fields and JSON 
structure are preserved. Recognition remains heuristic rather than a complete 
secret detector.
   
   ### How was this patch tested?
   
   - `python3 -m pytest -q`: 233 passed, 3 subtests passed. Tests cover quoted 
spaces/colons/escaped quotes, short values, JSON persistence, a value equal to 
its key, and 14 bare/quoted prefixed-key cases.
   - Root `-N spotless:apply` and `-N -DskipTests verify` passed. Modified 
Python files passed the fatal-error Ruff checks.
   - Full-repository `-DskipTests verify` was attempted but stopped at 
`seatunnel-engine-ui`: the npm mirror returned HTTP 403 for `tslib-2.3.0.tgz`. 
This is not a successful full-repository build.
   
   ### Check list
   
   * [x] No new JAR binary or dependency is added.
   * [x] EN/ZH documentation updated.
   * [ ] Incompatibility guide updated. Not applicable: no schema or 
configuration incompatibility.
   * [ ] Connector registration updates: not applicable.
   
   Implemented with Codex assistance; the reproduction and checks above were 
run against this branch.
   
   ---
   [![Compound 
Engineering](https://img.shields.io/badge/Built_with-Compound_Engineering-6366f1)](https://github.com/EveryInc/compound-engineering-plugin)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to