DanielLeens commented on issue #12647: URL: https://github.com/apache/seatunnel/issues/12647#issuecomment-6037718019
Thanks for the careful multi-topic analysis and for opening #12648. I checked the production caller as well as the patch. `currentOffsets` accumulates offsets topic by topic, while `RocketMqSourceSplitEnumerator` treats only a completely empty result as a cold start and otherwise overwrites start offsets only for queues present in the returned map. Keeping the earlier offsets and skipping the later unresolved topic is therefore the minimal containment for this path: it stops a route problem on one topic from rewinding every topic, while the skipped topic retains its existing first-offset fallback. Please keep the change limited to the `TOPIC_NOT_EXIST` plus route-available branch; other lookup failures should still surface rather than being converted into a partial resume. The new regression correctly needs to assert the actual offset value from the earlier topic, not just a non-empty map, and the cold-start case where every topic is skipped must remain empty. The Build is successful, but this is not in `dev` yet; please keep the issue open until #12648 completes review and merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
