SEZ9 commented on issue #10210: URL: https://github.com/apache/seatunnel/issues/10210#issuecomment-6051243496
Thanks for the proposal. Since the dialects in the table are already tracked as sub-issues (e.g. #10211, #10213, #10214), please follow davidzollo's note above and claim a dialect by commenting on the related sub-issue rather than here, so we avoid duplicate work like the SQL Server case already covered by #10573. One concern to settle up front: pulling Docker containers into connector-jdbc unit tests will increase CI time and may fail in environments without Docker. Could you describe how these tests will be gated so the regular unit test run still works without Docker, and what distinguishes them from the existing jdbc-e2e cases? Regarding point 3 (moving tests from jdbc-e2e to connector-jdbc): please keep that as a follow-up after the catalog/dialect coverage lands, and list which specific e2e cases are candidates so we can confirm no end-to-end coverage is lost. <!-- streview-comment:1592 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
