SEPURI-SAI-KRISHNA commented on PR #12648: URL: https://github.com/apache/seatunnel/pull/12648#issuecomment-6055964038
@SEZ9 this is up and ready for the final pass. Both asks are in at `96278d3cf`: - The corrected description is live. It no longer claims the single-topic test covers the all-skipped multi-topic case, and it carries the measured mutation notes: restoring the `return` fails only `testCurrentOffsets_laterTopicFailureKeepsOffsetsFromEarlierTopics`, 1 of 8 in the class, while mutating the skip to treat an unresolved topic as committed-at-zero fails the new test and the single-topic test together, 2 of 8. - `testCurrentOffsets_everyTopicMissingRetryRouteStillReportsAColdStart` sits in the same file as `testCurrentOffsets_laterTopicFailureKeepsOffsetsFromEarlierTopics` and `testCurrentOffsets_multipleTopicsAreMergedAcrossTheLoop`. Module is 26 tests, 0 failures, 0 errors. `spotless:check` clean with no reformatting. Build run `37651416943` is **completed/success** on the whole matrix, so there is no red leg to explain on this one. Keeping #12647 open until this merges, as you both asked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
