1328837476-hug commented on code in PR #12690:
URL: https://github.com/apache/seatunnel/pull/12690#discussion_r4220484101
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-maxcompute-e2e/src/test/java/org/apache/seatunnel/e2e/connector/maxcompute/MaxComputeIT.java:
##########
@@ -271,18 +273,43 @@ public void testReadColumn() {
config.put("project", "mocked_mc");
config.put("table_name", "test_table");
config.put("read_columns", Arrays.asList("ID", "NAME"));
- SeaTunnelSource<Object, SourceSplit, Serializable> source =
- new MaxcomputeSourceFactory()
- .createSource(
- new TableSourceFactoryContext(
- ReadonlyConfig.fromMap(config),
-
Thread.currentThread().getContextClassLoader()))
- .createSource();
+ SeaTunnelSource<Object, SourceSplit, Serializable> source =
createSource(config);
CatalogTable table = source.getProducedCatalogTables().get(0);
Assertions.assertArrayEquals(
new String[] {"ID", "NAME"},
table.getTableSchema().getFieldNames());
}
+ @Test
Review Comment:
I've removed the duplicate E2E test. The endpoint validation is covered by
`MaxcomputeSourceFactoryTest`, and all 11 tests pass. The existing read-column
integration test is still in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
