DanielLeens commented on issue #12694: URL: https://github.com/apache/seatunnel/issues/12694#issuecomment-6078555726
Classification: A / Connector-V2 ActiveMQ sink resource lifecycle and configuration contract. The leak report is valid: constructing a JMS Session and MessageProducer per write without closing them can exhaust broker and client resources. The current open-PR audit also found two overlapping implementations, #12695 and #12698, both claiming this issue. Please do not merge two independently maintained versions of the same lifecycle change. Consolidate the required work into one focused PR, then close the duplicate after an exact diff comparison. The retained implementation must create and reuse the Session/Producer once per client, close producer -> session -> connection on both normal shutdown and partial initialization failure, preserve existing options/defaults, keep broker URLs and credentials out of logs and exception text, and cover cleanup plus existing send behavior. #12695 has a cancelled Build; #12698 has a successful Build but still requires review. The issue is not fixed in dev yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
