Rangsh commented on PR #12662:
URL: https://github.com/apache/seatunnel/pull/12662#issuecomment-6097976397
Thanks @SwatiKumari250 for opening this, and thanks @DanielLeens for the
review. Following up on the coordination asked for on #12655.
@DanielLeens has since updated the direction there: #11545 merged into`dev`
on 2026-10-09, so finding 1 (no root`surefire.module.args` on`dev` ) is
resolved once this branch is rebased, and the conclusion is to keep this as the
single implementation rather than opening a replacement PR. So instead of
closing this, I'd like to collaborate on it directly. Since maintainer edits
are enabled on the branch, I can push the updates myself, and I'm happy to hand
any part back to @SwatiKumari250 if you'd prefer to do it.
My plan for this PR, matching the four points on #12655:
1. Rebase onto current`dev` .
2. Keep the scope to the POM behavior: drop the connector-level`<argLine>`
and the`java9+``--add-opens` profile (already done here), and restore the two
unrelated blank-line removals in the ASF license header (review finding 3). The
retained macOS ARM profiles stay limited to the`os.arch` /`os.name` overrides.
3. Fill in the PR description, including the JDK 17 verification:
a`connector-lance` test run with`-Dsurefire.jvm.args` deliberately excluding
the`--add-opens` flags, showing the flags arrive through the
root`${surefire.module.args}` .
4. The local-override scan and the`backend.yml``SUREFIRE_JVM_ARGS` cleanup
stay in a separate follow-up PR after this one merges, as agreed on the issue.
The fork workflow still needs approval to run (Build is`ACTION_REQUIRED` ) —
that needs a maintainer. I'll start on the rebase and the header fix unless
anyone objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
