SEZ9 commented on issue #12721:
URL: https://github.com/apache/seatunnel/issues/12721#issuecomment-6104763461

   Thanks for the detailed report and root-cause analysis. Pointing the default 
`SEATUNNEL_API_BASE` at the port that serves `/running-jobs`, `/option-rules`, 
`/submit-job` and `/job-info` (`seatunnel.engine.http.port`, 8080 by default) 
rather than the Hazelcast member port sounds like the right fix. Since you are 
willing to submit a PR, please go ahead.
   
   Two suggestions for the PR:
   
   - Consider making the engine-unavailable fallback non-silent, e.g. log a 
warning with the probed URL and HTTP status when `_check_engine()` fails. A 404 
from a reachable host is a strong hint of a wrong base URL and should not be 
hidden behind the offline-metadata path.
   - Please update any docs that mention `SEATUNNEL_API_BASE` so the default 
matches `seatunnel.engine.http.port`, and note the `/hazelcast/rest/maps` 
context path for anyone who deliberately points it at the member port.
   
   As you noted, the `/run` behaviour change is worth calling out in the 
release note.
   
   <!-- streview-comment:1665 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to