DanielLeens commented on issue #12715: URL: https://github.com/apache/seatunnel/issues/12715#issuecomment-6108866457
Classification: A / Connector-V2 Doris source resource lifecycle. The source evidence is sound: `DorisSourceReader.pollNext()` replaces `valueReader`, and `DorisValueReader.close()` is the path that closes the scanner and client connection. #12718 correctly targets the handoff before the next split, but it is not ready as submitted. It stacks the unrelated WebSocket and MD5 commits from #12716 and #12717, has no Doris regression coverage, and therefore cannot be reviewed as an isolated repair. Please reduce the branch to this Doris change on current `dev` and add deterministic coverage that proves each completed split closes its reader exactly once, the final reader is still closed at reader shutdown, and cleanup happens when read or collection fails. A `try/finally` around each consumed split is the safer lifecycle boundary than waiting for the next poll to trigger cleanup. Preserve the existing checkpoint-lock behavior and do not broaden the change into async-fetch logic. The current Build is ACTION_REQUIRED and review is pending; the issue is not fixed in dev. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
