DanielLeens commented on PR #12318: URL: https://github.com/apache/seatunnel/pull/12318#issuecomment-6109461485
Quick CI update for @goutamadwant. In my last review (head `12d861e23`) the fork `Build` run was still queued, so I had no CI result. It has now finished with `failure`: 77 jobs passed, 6 failed, 11 were skipped. I went through the failed jobs, and none of them look related to this diff. Everything in this PR's own area is green: - `SQLNumericComparisonTest` ran 360 tests with 0 failures, and `ZetaSQLFilterTest` passed. - Both `transform-v2-it-part-1` and `transform-v2-it-part-2` passed on Java 11 and 17. The 6 failures: - `elasticsearch-connector-it` (11 and 17): `ElasticsearchIT` slice tests, with "iterable lengths differ" and "contents differ" assertions. This is an index-visibility race. `dev` already has the fix in #12711 (`Poll for index visibility in ElasticsearchIT slice tests`), merged after this branch's last sync. - `engine-v2-it (17)`: `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck`. This is the engine's cancel-vs-worker-loss behavior, not SQL. - `unit-test (11, ubuntu)`: `CoordinatorServiceJobCleanupTest` failed with "Node failed to start!" in `AbstractSeaTunnelServerTest.before`. This is a Hazelcast startup flake in the engine-server module. - `engine-k8s-it` (11 and 17): the "install k8s" step failed with "Download failed". This is a CI environment problem, before any test ran. Suggested next step: 1. Merge the latest `dev` into this branch (it is now 13 commits behind, and the ES fix is in that range). 2. Rerun only the failed jobs. In the Actions run for your fork, use "Re-run failed jobs" rather than rerunning the whole workflow. My source-side finding from the last review is unchanged: Issue 1, the stale unary-minus-on-DECIMAL wording in the EN/ZH `sql.md` and `incompatible-changes.md`. It is a docs-only change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
