Rangsh commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6110271828
Thanks @DanielLeens. Both non-blocking items are addressed in `ea8fb3c38`. **Issue 1:** `testAllBlockingDeployFailureAfterWorkersStartedCompletesAsFailed` no longer releases the workers from the test body. They stay blocked in `call()` until rollback's `cancel(true)` interrupts them, then return `DONE`. The countdown remains only in `finally` for cleanup, so `taskDone` cannot observe a clean completion before the deploy failure is recorded. **Issue 2:** `rollbackPublishedDeployment` now wraps `abortAfterFailedPublish` the same way as the classloader release. If cancellation throws anything other than the `CancellationException` already swallowed inside `cancelAllTask()`, the failure is added as suppressed and logged, and the stale `executionContexts` removal still runs. `TaskExecutionServiceTest` is green locally (27 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
