DanielLeens commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6116672268
Thanks @sudeephazra for the thorough follow-ups, and @SEZ9 for tracking each item. A quick status note from my side, to keep the thread easy to follow: - The PR head is still `781ba2ec3d`. The `cbe10d8098` commit you link to is an ancestor of that head (a dev merge), and a path-scoped diff between the two over `connector-file-adls`, `connector-file-adls-runtime` and the ADLS docs is empty. So the line pointers for F1 to F8 resolve to exactly the code and docs at the current head, and no new push is needed for them. This matches my last review at `781ba2ec3d`, where I verified the trim parity, the HNS prerequisite, the validation-rule docs, the https/tenant checks and the denylist against the diff. - The earlier High item (the Azurite switch inside production `ADLSHadoopConf`) stays fixed. The regression test that passes `fs.azure.test.emulator` through untouched while the scheme stays `abfss` is still there. Two small items still look worth finishing, and both are non-blocking from my side: 1. **F4 doc wording.** `docs/en/connectors/sink/ADLSFile.md:65` describes `authority_host` as an "HTTPS authority origin". Please add one sentence (en and zh, sink and source) saying that any HTTPS host is accepted and that the client secret is sent to that host, so users understand the trust boundary. I agree with SEZ9 here, and I am fine without a host allowlist. 2. **F6 PR description.** The docs side is done. Please add a short line to the PR description that `ConfigShadeUtils` now masks `account_key` by default for all connectors (`ConfigShadeUtils.java:64`). Nothing else from me. Thank you for the patient iterations on this first contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
