zhangshenghang commented on PR #12730: URL: https://github.com/apache/seatunnel/pull/12730#issuecomment-6119077757
Thanks @DanielLeens and @SEZ9 — addressed on head `2433602e`: **Issue 1 (must-fix)**: reverted `file_format_type` to required in LocalFile (en/zh) — you're right that `FileBaseSourceOptions.FILE_FORMAT_TYPE` has `noDefaultValue()` and `ReadStrategyFactory` dereferences it unconditionally. **Issue 2 (must-fix)**: removed the `schema_save_mode` / `data_save_mode` rows from BosFile, CosFile, ObsFile and OssJindoFile (en/zh, 24 rows total). Those sinks extend `BaseFileSink` which implements only `SeaTunnelSink` — the rows belong to `BaseMultipleTableFileSink` sinks only. **Issue 3**: the `schema_evolution_enabled` row on BosFile is removed as part of the same cleanup (also BaseFileSink, no `SupportSchemaEvolutionSink`). **Issue 5**: restored `UInt8 / UInt16` (and `Int8 / Int16`) into the sink table's INT row (en/zh). **Issue 6**: added the `STAIN_TRACE` row to the EventType table (en/zh) and switched `stain-trace-quickstart.md` to the canonical `stain-trace-sample-rate` key (`-interval` remains only as a code-level compatibility alias). **Issues 4 and 7** (ObsFile STS section rewrite, `plugin_input` string-form wording and the Iceberg `table_list` split example): will take these in a follow-up to keep this review round tight — happy to fold them in here instead if you prefer. Website build was green at `81961ee4`; this round only touches existing tables/rows, so I expect the same. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
