nzw921rx opened a new pull request, #12739:
URL: https://github.com/apache/seatunnel/pull/12739

   ### Purpose of this pull request
   
   Fix a CI regression introduced by #12429 that turns the 
`all-connectors-it-2` connector shard red on both JDK 11 and 17 (it is red on 
`dev` too, e.g. [run 
38211579427](https://github.com/apache/seatunnel/actions/runs/38211579427)).
   
   #12429 changed the *shared* `cassandra_to_cassandra.conf` so the source/sink 
hosts contained an unreachable seed (`cassandra:1,cassandra:9042`), and placed 
a client-level assertion (`testUnavailableBootstrapContactPoint`) inside the 
`CassandraIT` suite. That configuration drives the pipeline ITs 
(`testCassandra`, `testCassandraMultiTableSource`), so those jobs started to 
depend on driver-side failover.
   
   This PR:
   
   - restores the single reachable seed in `cassandra_to_cassandra.conf`, so 
the pipeline jobs no longer depend on failover;
   - removes `testUnavailableBootstrapContactPoint` from `CassandraIT` (the 
file is now identical to its pre-#12429 state);
   - keeps the coverage in a dedicated `CassandraBootstrapContactPointsIT`: its 
own Cassandra container, `TestResource` lifecycle, and an assertion that an 
unreachable seed never hides a reachable one, in both seed orders.
   
   The production fix in `CassandraClient` (registering every configured 
contact point on one builder) is untouched.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test-only change.
   
   ### How was this patch tested?
   
   - `./mvnw -B -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cassandra-e2e test-compile 
-Dskip.spotless=true`
   - `./mvnw -q -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cassandra-e2e spotless:check`
   - The new IT needs a Cassandra container; run it with:
     `./mvnw -B -pl 
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cassandra-e2e -am verify 
-DskipUT=true -DskipIT=false -Dit.test=CassandraBootstrapContactPointsIT 
-DfailIfNoTests=false -Dskip.spotless=true -Pci`
   
   Note: the new IT was compile-verified only in the environment where this PR 
was prepared (the `cassandra:4.1.1` image could not be pulled there).
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   
   None of the check-list items apply: this PR only adjusts test code for an 
existing connector, adds no dependency, no documentation, no configuration and 
no shaded jar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to