201811510411lw commented on PR #12366: URL: https://github.com/apache/seatunnel/pull/12366#issuecomment-6137021741
@SEZ9 Thanks for the review. I have completed the requested updates: 1. Added the three non-blocking follow-up items to the PR description. 2. Replaced the fully qualified `java.util.Optional` reference with an import. 3. Synced the branch with Apache `dev` and resolved the EN/ZH compatibility-note conflict and indentation issue. The latest CI run for head `b43bc2876` still has two failing jobs: `all-connectors-it-2` on JDK 11 and JDK 17. Both fail in the same Cassandra tests with `OutOfMemoryError: Direct buffer memory`. I compared them with the exact Apache `dev` base commit `83603e19`. The corresponding Apache CI run already fails in the same two tests with the same Flink 1.20.1 direct-memory error: - [Apache JDK 11 job](https://github.com/apache/seatunnel/actions/runs/38142199131/job/114478808743) - [Apache JDK 17 job](https://github.com/apache/seatunnel/actions/runs/38142199131/job/114478808737) Therefore, these Cassandra failures are pre-existing on `dev` and were not introduced by this PR. The remaining follow-up improvements can be handled in later PRs, as discussed. The current PR CI result is documented here: https://github.com/201811510411lw/seatunnel/actions/runs/38197997826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
