SEZ9 commented on issue #12723: URL: https://github.com/apache/seatunnel/issues/12723#issuecomment-6137990868
Thanks @chovy-3012, that plan lines up with the review scope on all four points — a separate reverse (BigQuery → SeaTunnel) mapping with explicit tests for null, BYTES, NUMERIC/BIGNUMERIC, DATE/TIME/TIMESTAMP, REPEATED and STRUCT; the exactly-one-read-mode option rule (`query` alone, or the complete `dataset_id` + `table_id` pair, with rejection when both or neither are set); explicit query execution, pagination, job cleanup on close and bounded-batch at-least-once delivery semantics in the PR description and EN/ZH docs; and extending the existing `connector-bigquery-e2e` suite rather than adding a new module. A few concrete asks for when the PR is ready: - Keep it to one focused PR and link it here so it can be tied back to this issue. - Make sure the type-mapping tests cover the REPEATED and STRUCT cases (including nested REPEATED-of-STRUCT), since those are the ones most likely to diverge from the sink's DDL mapping. - In the PR description, call out the exact validation error message for the both/neither read-mode case so reviewers can verify the behavior directly in the factory tests. - Please confirm no new third-party dependency is introduced by the source path. Nothing else is needed on this issue until the PR is linked. <!-- streview-comment:1724 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
