DanielLeens commented on PR #12134: URL: https://github.com/apache/seatunnel/pull/12134#issuecomment-6138720398
@SEZ9 I pushed `419000d09ee` to address the four remaining E2E review points from https://github.com/apache/seatunnel/pull/12134#issuecomment-6051770224. 1. The production redrive path is summarized in the PR description and remains visible in the current diff: `CoordinatorService#restoreJobFromMasterActiveSwitch` consumes `JobMaster#redriveSavepointAfterRestore` only after restore, then `redriveSavepointAfterMasterFailover` waits for `RUNNING` and invokes `savePoint()` on the restored master. 2. The test now fails if the client savepoint call completes before failover, and it re-checks both that the call is still pending and that an unacknowledged savepoint checkpoint is still present immediately before `masterNode1.shutdown()`. This prevents the test from passing through the old-master-completed scenario. 3. The private-field polling now uses Awaitility `ignoreExceptions()` so a transient read during coordinator state movement does not abort the poll. 4. The executor was already shut down in `finally` and the future was already joined at the end; the revision closes the missing outcome check. A pre-failover client failure now completes the future exceptionally and is surfaced as an assertion during the poll. Only an exception after master shutdown has started is treated as the expected broken RPC, and `savepointCall.get(...)` is still checked after the restored job reaches its terminal state. Verification on this head was intentionally limited to the allowed formatting checks: module-scoped `spotless:apply`, `spotless:check`, and `git diff --check` all passed. No local compile or test was run; GitHub CI on `419000d09ee` is the runtime verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
