davidzollo commented on PR #12096: URL: https://github.com/apache/seatunnel/pull/12096#issuecomment-6138903096
Closed the remaining positive-coverage gap in `f38eb282239`. `restoresCheckpointRetentionForCurrentSavepointJob` now constructs a coordinator with `isStartWithSavePoint=true` and a non-null `PipelineState` whose `jobId` matches the coordinator job. It verifies that the `restoresCurrentJob` branch reloads persisted checkpoint ids and immediately applies the configured retention limit. This complements the existing mismatched-job negative case and the active-master-switch positive case, so both sides of the constructor's recreation condition now have direct coverage. Validation performed (per the task's local-execution restriction): module-scoped `spotless:apply`, `spotless:check`, and `git diff --check` all passed. I did not run local compilation or tests. The push also creates a fresh CI run, replacing the prior attempt-2/exhausted result for the old head. The separate best-effort deletion suggestion remains non-blocking and intentionally unchanged here: it would broaden storage error semantics beyond this focused retention-recreation fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
