CodeWithPravinMaske commented on PR #12597: URL: https://github.com/apache/seatunnel/pull/12597#issuecomment-6139083135
Thanks @SEZ9! All of these are in the current head (`4a0cc3d2e`): the second test is `splitColumnPrefersNotNullUniqueKeyOverNullablePrimaryKey`; `isColumnNullable` now tries a case-insensitive match and logs a WARN naming the table and column before falling back to the parsed column; the Javadoc documents when it's called, the one `getColumns` query per call, and that dialects may override it; the E2E compares `id, name`. Comparing `code` isn't possible here: NULL arriving as `0` is #12599, fixed in #12608, which merges after this PR. I kept the per-table metadata lookup as discussed with @DanielLeens. CI is green on the current head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
