CryoThrust commented on issue #12734: URL: https://github.com/apache/seatunnel/issues/12734#issuecomment-6139668362
One distinction for the requested discovery-joiner regression, checked on `dev` at `b0f6fedd`: **a discovered but temporarily unreachable master** and **no master address discovered before the discovery wait expires** exercise different paths. The TCP/IP parent calls `getPossibleAddressesForInitialJoin()` once before its retry loop ([source](https://github.com/apache/seatunnel/blob/b0f6feddf9ed0dc1f5d485cfc69d387edfe6ac82/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/joiner/LiteNodeDropOutTcpIpJoiner.java#L145)). The discovery subclass polls only until `WAIT_SECONDS_BEFORE_JOIN`, then returns an empty collection ([source](https://github.com/apache/seatunnel/blob/b0f6feddf9ed0dc1f5d485cfc69d387edfe6ac82/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/joiner/LiteNodeDropOutDiscoveryJoiner.java#L71)). `tryJoinAddresses` retries that collection; it does not refresh discovery. Clearing a temporary blacklist therefore cannot add an address that was absent from the initial snapshot. For this PR, a discovery fixture that returns the master address before its port is ready would verify the inherited retry fix requested above. An initially empty discovery result with a master appearing only after that first wait is a separate address-refresh scenario, even if the overall join deadline has not expired. I would label that distinction in the test/PR rather than claim the blacklist fix covers both. Refreshing discovery under the existing overall deadline could be a follow-up if the community wants that startup contract. This is a source-trace observation, not a live-cluster reproduction. Keeping the first patch focused on your existing proposal makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
