SEZ9 commented on PR #11702: URL: https://github.com/apache/seatunnel/pull/11702#issuecomment-6160492249
Thanks for the rebase. The current head (`3f9d7a8648`) is content-identical to the version I reviewed earlier (`533a1e4`): exact `JobLogFileNameMatcher` matching replacing the `contains` check, the `RollingFile` appender, the `startPrune` TTL pruner, and the `MDCContext` `JobMode` dimension with the legacy 3-segment format still round-tripping. From the code side I don't see a blocker. The only open item is CI: the fork `Build` run is red on `all-connectors-it-2` (JDK 11 and 17), where `CassandraIT.testCassandra` and `testCassandraMultiTableSource` fail on the Flink 1.20 variant. This PR doesn't touch Cassandra or Flink 1.20, and those same failures were already fixed on `dev` after this run; the branch is behind `dev` and doesn't carry that fix yet. Suggested next steps: 1. Sync the latest `dev` into your branch (no code changes expected). 2. Re-run the failed `all-connectors-it-2` jobs and drop the check link here. 3. If anything other than the two Cassandra tests fails after the sync, paste the failing test names/log and I'll take a look. Note that a committer approval is still required for merge, as my account is comment-only. <!-- streview-comment:1746 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
