SEZ9 commented on PR #11775: URL: https://github.com/apache/seatunnel/pull/11775#issuecomment-6160519527
Thanks for the continued hardening here. The current head still looks solid to me: the opt-in, config-driven scheduler created once per node, the dedicated `seatunnel-metrics.log` routed through an `additivity=false` Log4j2 logger, the duplicate merge-with-history logic extracted into a shared private helper, and `metricsLoggingScheduler` now `final` as of `5ad1c31a`. No code-side blocker from my side. On the CI for `c541b2b946`: the `Build` run is red only on `all-connectors-it-2` (JDK 11 and 17), where `CassandraIT.testCassandra` and `testCassandraMultiTableSource` fail on the Flink 1.20 variant. This PR does not touch Cassandra, and those tests were addressed on `dev` by #12756, which this branch does not contain yet. Could you sync the latest `dev` into the branch and re-run the failed `all-connectors-it-2` jobs? If anything other than the Cassandra tests still fails after that, please paste the new check link and I will take a look. As before, my approval is comment-only, so a committer approval is still needed to merge. <!-- streview-comment:1748 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
